Test postgres multi-schema introspection #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
changed the title
The test expectations show that there are cases where our choice _not_ to rename models and enums in case of conflict leads to ambiguous situations that may be difficult for users to resolve. The test case where this is the most apparent is `multiple_schemas_w_duplicate_enums_are_introspected`. closes prisma/prisma#15800
tomhoule
force-pushed
the
ie/multi-schema-crash-2
branch
from
177c279
to
2df162b
Compare
pimeys
approved these changes
Nov 25, 2022
I'll try to think of more multi-schema specific cases, and maybe open an issue about the multi-schema specific model/enum ambiguities in introspection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test expectations show that there are cases where our choice not
to rename models and enums in case of conflict leads to ambiguous
situations that may be difficult for users to resolve. The test case
where this is the most apparent is
multiple_schemas_w_duplicate_enums_are_introspected.closes prisma/prisma#15800