fix(pg): error out on overflowing integer #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add tests following up on quaint's PR prisma/quaint#415 to validate integers before they're sent to Postgres so that they don't overflow.
Previous work was done at the QE level here (#3231) before we reverted it because we didn't want MongoDB to error out on overflowing integers (since MongoDB technically supports integers higher than i32 for an
Integercolumn).Furthermore, all SQL connectors already errored out except for Postgres. This PR is much lighter than the previous one and really only fixes the issue, while adding regression tests for the future on all connectors.
TODO