-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render composite types with the new renderer #3317
Render composite types with the new renderer #3317
Conversation
82db30b
to
035425d
Compare
3ff55d7
to
9e7163b
Compare
9e7163b
to
bfe8426
Compare
/// Here to cope with the initial issue of needing the DML | ||
/// structures. Remove when we don't generate DML in intro | ||
/// anymore. | ||
pub fn from_dml(val: &'a dml::DefaultValue) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here might be some dragons. We'll see when models and fields are converted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I'm still not visualizing the full picture with this data structure when we cut out dml from introspection and stop re-rendering everything, but rather express the introspection result as inserts/removals on the original schema (that's probably what it will take if we want to preserve comments). Let's keep pushing forward and see how things pan out
Part of: prisma/prisma#15800