fix: re-introspection now preserves 'referentialIntegrity' policy #3337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolg42
reviewed
Oct 26, 2022
introspection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/mssql.rs
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Oct 26, 2022
...ospection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/postgres.rs
Outdated
Show resolved
Hide resolved
Jolg42
reviewed
Oct 26, 2022
introspection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/sqlite.rs
Outdated
Show resolved
Hide resolved
Jolg42
approved these changes
Oct 26, 2022
tomhoule
reviewed
Oct 26, 2022
introspection-engine/datamodel-renderer/src/configuration/datasource.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
tomhoule
reviewed
Oct 26, 2022
introspection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/mssql.rs
Outdated
Show resolved
Hide resolved
introspection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/mysql.rs
Outdated
Show resolved
Hide resolved
...ospection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/postgres.rs
Outdated
Show resolved
Hide resolved
introspection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/sqlite.rs
Outdated
Show resolved
Hide resolved
...ospection-engine/introspection-engine-tests/tests/re_introspection/relation_mode/postgres.rs
Outdated
Show resolved
Hide resolved
tomhoule
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
referentialIntegrity = "prisma"orreferentialIntegrity = "foreignKeys"information in thedatasourceblock was lost during re-introspection. This was caused by us renaming thereferentialIntegrityfield torelationMode, while keeping the preview feature name asreferentialIntegrity.Now, if the input schema has, e.g.,
referentialIntegrity = "prisma", the re-introspected schema keeps this value under the renamed linerelationMode = "prisma".Fixes prisma/prisma#16007.