qe: Identify which request in a batch caused error #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
force-pushed
the
feat/error-req-idx
branch
from
245caac
to
689eb59
Compare
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 11, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
Adds `batch_request_idx` property to user facing errors. On the client, that would allow us to build correct error message for `$transaction` errors. Ref: prisma/prisma#15433, prisma/prisma#14373
SevInf
force-pushed
the
feat/error-req-idx
branch
from
689eb59
to
26e00ab
Compare
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 11, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 11, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
miguelff
reviewed
Nov 11, 2022
aqrln
reviewed
Nov 12, 2022
Comment on lines
+53
to
55
| .await; | ||
|
|
||
| histogram!(PRISMA_CLIENT_QUERIES_HISTOGRAM_MS, operation_timer.elapsed()); |
There was a problem hiding this comment.
This might be an unintentional change, but previously this metric wouldn't have been logged if there was an error, right? The new behaviour sounds more correct to me, but we might want to check what happens in other places and if it's consistent.
There was a problem hiding this comment.
Yep, in execute_single_query we write this histogram regardless of whether the result is Ok or Err. Looks like another unrelated bug fixed here at the same time 😄
There was a problem hiding this comment.
Even amount of errors = correct result 😆
garrensmith
suggested changes
Nov 14, 2022
There was a problem hiding this comment.
This is nice and clean. I agree with @miguelff could you add a test cause for this so we know it works as expected.
Comment on lines
+53
to
55
| .await; | ||
|
|
||
| histogram!(PRISMA_CLIENT_QUERIES_HISTOGRAM_MS, operation_timer.elapsed()); |
|
@miguelff @garrensmith now second attempt: this time a proper test, not the snapshot one |
miguelff
approved these changes
Nov 14, 2022
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 14, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
garrensmith
approved these changes
Nov 15, 2022
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 15, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 15, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 16, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 16, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 17, 2022
Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
Nov 17, 2022
…6240) Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
jkomyno
pushed a commit
to prisma/prisma
that referenced
this pull request
Dec 21, 2022
…6240) Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
jkomyno
pushed a commit
to prisma/prisma
that referenced
this pull request
Dec 21, 2022
…6240) Engine PR: prisma/prisma-engines#3384 Uses newly added `batch_request_idx` property of an errors to identify and correctly report error location within a batch. Fix #15433 Fix #14373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
batch_request_idxproperty to user facing errors. On the client,that would allow us to build correct error message for
$transactionerrors.
Ref: prisma/prisma#15433, prisma/prisma#14373