feat(fmt): add quick-fix for missing indexes when relationMode = "prisma" #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added quickfix to add indexes for relations when RelationMode=Prisma fixes #1297 Co-authored-by: Tom tom@tomhoule.com
|
|
|
waiting on #3429 |
Druue
changed the title
Druue
commented
Nov 23, 2022
Jolg42
reviewed
Nov 23, 2022
Jolg42
reviewed
Nov 23, 2022
…e end of a block Updated: `create_missing_unique` ~> `create_missing_attribute` + `create_block_attribute`
pimeys
reviewed
Nov 23, 2022
prisma-fmt/tests/code_actions/scenarios/relation_mode_prisma_missing_index/result.json
Outdated
Show resolved
Hide resolved
|
ok
|
Druue
commented
Nov 24, 2022
…relation_mode-indexes
…n; also updated schema.prisma to be mysql relationmode
eviefp
approved these changes
Nov 25, 2022
janpio
reviewed
Nov 25, 2022
prisma-fmt/tests/code_actions/scenarios/relation_mode_prisma_missing_index/diagnostics.json
Outdated
Show resolved
Hide resolved
|
Let's merge #3447 then rebase this |
janpio
reviewed
Nov 25, 2022
| } | ||
| }, | ||
| "severity": 1, | ||
| "message": "With `relationMode = \"prisma\"`, no foreign keys are used, so relation fields will not benefit from the index usually created by the relational database under the hood. This can lead to poor performance when querying these fields. We recommend adding an index manually. Learn more at https://pris.ly/d/relation-mode#indexes" |
There was a problem hiding this comment.
I think the message was updated in the meantime, but as this is just input and expectation at the same time (And does not use the actual correct warning), this should be fine.
(Or should this actually be wired up to the real warning?)
|
Let's merge this (checked with Soph on Slack) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added quickfix to add indexes for relations when RelationMode=Prisma
-- where
@@indexdid not existcloses #1297