Fix a crash with a special case of dbgenerated() #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug is triggered by the following combination of _things_: - MySQL - Use of `dbgenerated()` (a deliberatly empty one) - Native type of `Time` If you have this in the PSL, pushing twice will panic. What happens is two things: we think the value `time(0)` from the database is diffed as a different value what is `Time` in the PSL. This is unneeded drift and should not happen. The second issue is when the change is adding a `dbgenerated()` to a field, which is not really done by the users due to it not being very useful (and a legacy structure). Now, our MySQL rendering does not think somebody would _add_ a `dbgenerated()` to the PSL. But, if you combine it with thinking `db.Time` and `time(0)` are different, getting another migration from the second push... Now we hit the `unreachable()` and crash.
tomhoule
approved these changes
Dec 15, 2022
migration-engine/migration-engine-tests/tests/native_types/mysql.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is triggered by the following combination of things:
dbgenerated()(a deliberatly empty one)TimeIf you have this in the PSL, pushing twice will panic.
What happens is two things: we think the value
time(0)from the database is diffed as a different value what isTimein the PSL. This is unneeded drift and should not happen.The second issue is when the change is adding a
dbgenerated()to a field, which is not really done by the users due to it not being very useful (and a legacy structure). Now, our MySQL rendering does not think somebody would add adbgenerated()to the PSL. But, if you combine it with thinkingdb.Timeandtime(0)are different, getting another migration from the second push... Now we hit theunreachable()and crash.Closes: prisma/prisma#16340
Closes: prisma/prisma#9769
Closes: prisma/prisma#6382