me: Fix schema handling in migration persistence #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
me/fix-schema-handling-in-persistence
branch
2 times, most recently
from
c7f3223
to
97fab90
Compare
pimeys
commented
Dec 22, 2022
| @@ -121,12 +121,10 @@ fn multi_schema_reset(mut api: TestApi) { | |||
| }} | |||
| "#, api.datasource_block_with(&[("schemas", r#"["felines", "rodents"]"#)]) | |||
| }; | |||
| api.schema_push(&prisma_schema) | |||
There was a problem hiding this comment.
This was broken and we didn't realize it before. What happens:
- We push the schema
- We then apply migrations, which creates the persistence
- The persistence cannot find the
_prisma_migrationstable - Before it was ok, but now we look into all the schemas given, so it finds the pushed tables but no migrations table
- We error out.
What we should do is to use migrate, which creates the migrations table and allows us to continue.
pimeys
force-pushed
the
me/fix-schema-handling-in-persistence
branch
from
97fab90
to
5f882a5
Compare
pimeys
force-pushed
the
me/fix-schema-handling-in-persistence
branch
from
5f882a5
to
a11d4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: prisma/prisma#16585