-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fmt): completions <> DataSource property schemas
#3541
Conversation
Co-authored-by: Tom Houlé <13155277+tomhoule@users.noreply.github.com>
schemas
completionschemas
Added pretty doc func
@Druue How can anyone try this PR? |
It seems I'm stuck and cannot review this, maybe someone else can, @pimeys ? any idea what to do here? I ran the script which runs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datasource db { | ||
provider = "postgresql" | ||
url = env("DATABASE_URL") | ||
<|> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have a bug with no completion showing up at the beginning of a line, it would make sense to duplicate this test and also test the beginning of the line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to figure out how to merge completions prisma/language-tools#1347 first before we can merge this
Or move all the datasource completions to Rust
Or alternatively redo this in the TS codebase
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should fix prisma/prisma#17000
Isn't that an existing, higher level problem though @Jolg42 that should not really block adding this completion? |
@janpio We decided with @Druue to
|
closes prisma/prisma#16920
Co-authored-by: Tom Houlé 13155277+tomhoule@users.noreply.github.com