SQLite view introspection, flavours #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
intro/sqlite_view_intro
branch
from
375ae4a
to
3819a86
Compare
tomhoule
approved these changes
Mar 1, 2023
|
|
||
| let file = database_url.trim_start_matches("file:"); | ||
| std::fs::remove_file(&file).ok(); | ||
| } |
There was a problem hiding this comment.
I think there's sqlite_test_file() in test_setup that does the sqlite file truncation too.
There was a problem hiding this comment.
Actually, I'm already using this through sqlite_test_url. It somehow uses the same file in the subsequent runs... Therefore removing it here.
| && self.context.sql_family.is_postgres(); | ||
|
|
||
| if keep_previous_arity { | ||
| if self.context.flavour.keep_previous_scalar_field_arity(self.next) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotchas:
Closes: prisma/prisma#17416