query-engine: merge schema and schema-builder crates
#3910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
qe-merge-schema-and-schema-builder
branch
3 times, most recently
from
b19358c
to
275c6c9
Compare
Currently, many items are exported publicly from `schema` because they are needed in `schema-builder`, and vice versa, but they are not part of the useful public API to the rest of the workspace. Merging the two crates will let us make a lot of things private: we'll have a smaller, clearer API contract and we'll be free to refactor how that API is implemented without breaking query_core and dmmf. closes https://github.com/prisma/client-planning/issues/346
tomhoule
force-pushed
the
qe-merge-schema-and-schema-builder
branch
from
275c6c9
to
e998a70
Compare
CodSpeed Performance ReportMerging #3910 Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many items are exported publicly from
schemabecause they are needed inschema-builder, and vice versa, but they are not part of the useful public API to the rest of the workspace.Merging the two crates will let us make a lot of things private: we'll have a smaller, clearer API contract and we'll be free to refactor how that API is implemented without breaking query_core and dmmf.
closes https://github.com/prisma/client-planning/issues/346