Stopgap: MongoDB $jsonSchema #3953
Conversation
| if let Some(walker) = doc_count.collection_walker { | ||
| if walker.has_schema() { | ||
| model.documentation("json schema msg") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This adds the documentation message that goes into the schema file above the model
There was a problem hiding this comment.
Let's make sure we agree on the message to render, before accepting json schema msg in this PR :)
| render_warnings( | ||
| "The following models have a JSON Schema defined in the database, which is not yet fully supported. Read more: https://pris.ly/d/todo", | ||
| &self.json_schema_defined, | ||
| f | ||
| )?; |
There was a problem hiding this comment.
This adds the cli warning message
There was a problem hiding this comment.
Also, let's make sure we give the pris.ly link a proper URL. https://pris.ly/d/mongodb-jsonschema should be good enough
CodSpeed Performance ReportMerging #3953 Summary
|
| if let Some(walker) = doc_count.collection_walker { | ||
| if walker.has_schema() { | ||
| model.documentation("json schema msg") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's make sure we agree on the message to render, before accepting json schema msg in this PR :)
| if let Some(walker) = doc_count.collection_walker { | ||
| if walker.has_schema() { | ||
| model.documentation("json schema msg") | ||
| } | ||
| } |
There was a problem hiding this comment.
I would be tempted to refactor this into an Option::filter just to avoid two nested ifs, but this is just a minor nit
| render_warnings( | ||
| "The following models have a JSON Schema defined in the database, which is not yet fully supported. Read more: https://pris.ly/d/todo", | ||
| &self.json_schema_defined, | ||
| f | ||
| )?; |
There was a problem hiding this comment.
Also, let's make sure we give the pris.ly link a proper URL. https://pris.ly/d/mongodb-jsonschema should be good enough
part of https://github.com/prisma/schema-team/issues/403
contributes to: prisma/prisma#8135