qe: filter out unique criteria containing an unsupported field #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
query-engine-prisma-18517
branch
from
ad689bc
to
c5d211e
Compare
CodSpeed Performance ReportMerging #3960 Summary
|
miguelff
approved these changes
May 8, 2023
| @@ -54,6 +54,9 @@ impl Model { | |||
| } | |||
|
|
|||
| pub fn unique_indexes(&self) -> impl Iterator<Item = walkers::IndexWalker<'_>> { | |||
| self.walker().indexes().filter(|idx| idx.is_unique()) | |||
They are not usable by the query engine, and currently cause crashes whenever querying the model containing them. closes prisma/prisma#18517
tomhoule
force-pushed
the
query-engine-prisma-18517
branch
from
c5d211e
to
c29f5c5
Compare
aqrln
added a commit
that referenced
this pull request
Sep 8, 2023
Fix DMMF generation for schemas with compound `@@id` or `@@unique` that contain unsupported fields. Previously DMMF generation would panic with ``` unreachable code: No unsupported field should reach that path', query-engine/schema-builder/src/input_types/mod.rs:26:40 ``` The issue with compound unique was re-introduced in Prisma 4.16 in #3977 after being previously fixed in Prisma 4.14 in #3960. The issue with compound id is a new one, and is reproducible with Prisma 4.14 as well. Fixes: prisma/prisma#20986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not usable by the query engine, and currently cause crashes whenever querying the model containing them.
closes prisma/prisma#18517