fix(fieldRef): generic args in ts client #3989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cannot find name '$PrismaModel'
due to featureextendedWhereUnique
with preview featurefieldReference
prisma#16997It's hard to connect the changes to the actual fix. Setting the
WhereInputType
object tag to theWhereUniqueInput
object types allows the DMMF renderer to add ameta: { source: "<model_name>" }
property to the input object types, which the client eventually use to decide whether or not a generic is needed for the generated TypeScript types.What happened is that we first implemented field refs, then we implemented the extendedWhereUnique feature, but forgot to add the required tag to
WhereUnique
input objects, which made both features incompatible.