Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: merge engine-size and cargo-docs #4134

Merged
merged 1 commit into from
Aug 15, 2023
Merged

ci: merge engine-size and cargo-docs #4134

merged 1 commit into from
Aug 15, 2023

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Aug 11, 2023

@Jolg42 Jolg42 added this to the 5.2.0 milestone Aug 11, 2023
@Jolg42 Jolg42 requested a review from a team as a code owner August 11, 2023 13:54
@Jolg42 Jolg42 requested a review from tomhoule August 15, 2023 07:42
tomhoule
tomhoule approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Jolg42 Jolg42 merged commit 8010039 into main Aug 15, 2023
5 checks passed
@Jolg42 Jolg42 deleted the joel/merge-engine-size-cargo-docs branch August 15, 2023 07:52
@Jolg42
Copy link
Contributor Author

Jolg42 commented Aug 15, 2023

Note: Internal Slack

Before
https://github.com/prisma/prisma-engines/actions/runs/5853915340 docs = 10min
https://github.com/prisma/prisma-engines/actions/runs/5853915332 engine sizes = 21min
Now
22 min
It looks like we saved 10 min with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jolg42 @tomhoule