node-drivers: node-postgres based driver for testing #4151
Conversation
CodSpeed Performance ReportMerging #4151 will not alter performanceComparing Summary
|
| super({ client: connection, isTransaction: true }) | ||
| class PgTransaction extends PgQueryable<TransactionClient> implements Transaction { | ||
| constructor(client: pg.PoolClient) { | ||
| super(client) |
There was a problem hiding this comment.
Isn't that equivalent to leaving the constructor out?
There was a problem hiding this comment.
Are you referring to the constructor(client) { super(client) } in a subclass of a class having a compatible constructor? Yes, it's indeed redundant. I find it easier to read, but feel free to remove it.
| } | ||
|
|
||
| /** | ||
| * Execute a query given as SQL, interpolating the given parameters and |
There was a problem hiding this comment.
The parameters aren't interpolated in quaint/tokio_postgres — is it different in PG?
There was a problem hiding this comment.
That series of comments is copied almost verbatim from
There was a problem hiding this comment.
We should fix that, at some point.
tomhoule
changed the title
tomhoule
force-pushed
the
new-pg-js-connector-branch
branch
from
f5a9add
to
0fceccc
Compare
To facilitate local evaluation and performance testing of the prototype. It follows the same patterns as the planetscale and neon drivers, and includes smoke tests. Co-authored-by: jkomyno <schiabel@prisma.io>
tomhoule
force-pushed
the
new-pg-js-connector-branch
branch
from
0fceccc
to
15a0bc1
Compare
| import { ColumnTypeEnum, type ColumnType } from '@jkomyno/prisma-js-connector-utils' | ||
| import { types } from 'pg' | ||
|
|
||
| const NeonColumnType = types.builtins |
There was a problem hiding this comment.
copy/paste or should this really say PgColumnType or similar?
To facilitate local evaluation and performance testing of the prototype.
It follows the same patterns as the planetscale and neon drivers, and
includes smoke tests.
Co-authored-by: jkomyno schiabel@prisma.io