feat(quaint): remove chrono conditional flag
#4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkomyno
changed the title
chrono conditional flag
CodSpeed Performance ReportMerging #4227 will not alter performanceComparing Summary
|
jkomyno
commented
Sep 13, 2023
Comment on lines
-340
to
-349
| #[cfg(not(feature = "chrono"))] | ||
| typ => { | ||
| let msg = format!( | ||
| "Value of type {:?} is not supported with the current configuration", | ||
| typ | ||
| ); | ||
|
|
||
| let kind = ErrorKind::conversion(msg); | ||
| Err(Error::builder(kind).build())? | ||
| } |
There was a problem hiding this comment.
This is worth double-checking.
However, since this PR effectively acts as if the chrono feature was applied 100% of the time, it should be safe to remove.
miguelff
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/prisma/team-orm/issues/354.