Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify error message for i32/i64 parsing #4429

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore: unify error message for i32/i64 parsing #4429

merged 2 commits into from
Nov 13, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 9, 2023 •
edited
Loading

This PR is the prisma-engines-counterpart of prisma/prisma#21849.

This PR contributes to https://github.com/prisma/team-orm/issues/514.

/integration

@jkomyno jkomyno self-assigned this Nov 9, 2023
@jkomyno jkomyno mentioned this pull request Nov 9, 2023
Merged
@jkomyno jkomyno marked this pull request as ready for review November 9, 2023 14:33
@jkomyno jkomyno requested a review from a team as a code owner November 9, 2023 14:33
@jkomyno jkomyno requested review from miguelff and Weakky and removed request for a team November 9, 2023 14:33
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 9, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4429 will not alter performance

Comparing fix/driver-adapters-message-i64-i32 (a32e486) with main (2963919)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno added this to the 5.6.0 milestone Nov 13, 2023
@jkomyno jkomyno merged commit e0f0b06 into main Nov 13, 2023
30 of 34 checks passed
@jkomyno jkomyno deleted the fix/driver-adapters-message-i64-i32 branch November 13, 2023 14:15
aqrln added a commit that referenced this pull request Nov 17, 2023
@aqrln
test(qe): update expected error in SQLite tests with driver adapters
5c3494c 
The error message was changed in
#4429 but wasn't updated
in the tests which resulted in them failing on main.

#4429
@aqrln aqrln mentioned this pull request Nov 17, 2023
Merged
miguelff pushed a commit that referenced this pull request Nov 17, 2023
@aqrln
test(qe): update expected error in SQLite tests with driver adapters (#…
aaed047 
…4462)

The error message was changed in
#4429 but wasn't updated
in the tests which resulted in them failing on main.

#4429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelff miguelff miguelff approved these changes

@Weakky Weakky Awaiting requested review from Weakky Weakky was automatically assigned from prisma/orm-rust-maintain

Assignees

@jkomyno jkomyno

Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkomyno @miguelff