fix(qe): make UpdateRecord::WithSelection nodes return RecordSelection
#4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4508 will not alter performanceComparing Summary
|
- Change `FieldSelection::matches` to mean that the current field selection is a subset of `SelectionResult` instead of a superset. - Project the selected tuple into the expected cardinality.
`SelectionResult::new` is not generic, compiler already knows the type.
This reverts commit d56319a.
…ion" This reverts commit 6ee982b.
aqrln
force-pushed
the
fix-qe-regression-in-queries-with-update-returning
branch
from
d5731c7
to
94c60ce
Compare
Even though there technically should be a need for name if the node's results don't need to be serialized and only fulfill the requirements of another node, we still need some name to build `RecordSelection`. Previously the update node with selection that has no name would return a `QueryResult::Id` instead of `QueryResult::RecordSelection` to work around that, but it caused problems as the query interpreter relied on `QueryResult::Id` being the primary identifier and not arbitrary fields. This commit makes the name required for `UpdateRecord::WithSelection` and provides a dummy name when the node doesn't directly correspond to user's query. This is consistent with other intermediate nodes that need to build `RecordSelection` and use dummy names (like `reload` or `find_children_by_parent`) or empty strings.
aqrln
changed the title
UpdateRecord::WithSelection nodes return RecordSelection
aqrln
commented
Dec 1, 2023
| @@ -200,7 +200,7 @@ where | |||
|
|
|||
| Query::Write(WriteQuery::UpdateRecord(UpdateRecord::WithSelection( | |||
| UpdateRecordWithSelection { | |||
| name: Some(field.name.to_owned()), | |||
There was a problem hiding this comment.
Removed to_owned() because field.name is already an owned string, and we don't need it anymore here so we can just move it without cloning.
miguelff
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query graph nodes that are not result nodes and fulfill the requirements of other nodes don't inherently need names because their results aren't serialized. However, we still need some name to be able to build
RecordSelectionbecause it's required there. Previously the update node with selection that has no name would return aQueryResult::Idinstead ofQueryResult::RecordSelectionto work around that, but it caused problems as the query interpreter relied onQueryResult::Idbeing the primary identifier and not arbitrary fields.This PR makes the name required for
UpdateRecord::WithSelectionand provides a stub name when the node doesn't directly correspond to the client's query. This is consistent with other intermediate nodes that need to buildRecordSelection. Some of them use constant placeholder names (likefind_children_by_parentforRelatedRecordsQuery), some of them use empty strings (e.g.CreateRecorddoes this).I chose an empty string because it needs to be owned here and an empty
String::new()doesn't allocate memory, and the specific value doesn't matter anyway because there's likely not even a way to observe this name (it's not used inDisplayandToGraphvizimpls forUpdateRecord).Fixes: prisma/prisma#21182