Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): wasm integration pipeline for prisma/prisma #4516

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 4, 2023

This PR closes https://github.com/prisma/team-orm/issues/680, and fixes Wasm's build.sh for main, borrowing logic from the vertical slice.

This should be merged AFTER the release.


Update: @aqrln reached out privately asking to merge this BEFORE the release, as it'd simplify integration PRs for Joins.

@jkomyno jkomyno self-assigned this Dec 4, 2023
@jkomyno jkomyno added this to the 5.7.0 milestone Dec 4, 2023
@jkomyno
Copy link
Contributor Author

jkomyno commented Dec 4, 2023

This PR generates the following package.json:

{
  "name": "@prisma/query-engine-wasm",
  "version": "<version>",
  "files": [
    "query_engine_bg.wasm",
    "query_engine.js",
    "query_engine_bg.js",
    "query_engine.d.ts"
  ],
  "module": "query_engine.js",
  "types": "query_engine.d.ts",
  "sideEffects": [
    "./query_engine.js",
    "./snippets/*"
  ],
  "type": "module",
  "main": "./query_engine.js",
  "private": false
}

Copy link

codspeed-hq bot commented Dec 4, 2023

CodSpeed Performance Report

Merging #4516 will not alter performance

Comparing fix/wasm-integration (33f67c5) with main (a0c366a)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno added this to the 5.7.0 milestone Dec 4, 2023
@jkomyno jkomyno marked this pull request as ready for review December 4, 2023 16:00
@jkomyno jkomyno requested a review from a team as a code owner December 4, 2023 16:00
@jkomyno jkomyno requested review from miguelff and Druue and removed request for a team December 4, 2023 16:00
@aqrln aqrln merged commit 845c140 into main Dec 4, 2023
32 checks passed
@aqrln aqrln deleted the fix/wasm-integration branch December 4, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants