Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix wasm build script #4519

Merged
merged 1 commit into from
Dec 5, 2023
Merged

ci: fix wasm build script #4519

merged 1 commit into from
Dec 5, 2023

Commits on Dec 4, 2023

  1. ci: fix wasm build script

    The build script had an invalid `sed` command with an extra `''`
    argument that caused it to fail with
    
    ```
    sed: can't read s/name = "query_engine_wasm"/name = "query_engine"/g: No such file or directory
    ```
    
    Example: https://github.com/prisma/prisma-engines/actions/runs/7090582268/job/19297872413
    
    This is reproducible both on CI and locally for me. Perhaps it was
    written for BSD sed and doesn't work with GNU sed (so it always fails on
    Linux and also fails on macOS inside prisma-engines Nix flake but maybe
    it works on macOS without Nix)?
    
    Because of this, a broken package was published from CI.
    
    The commit fixes the `sed` command and adds `set -e` so that errors like
    this would fail CI instead of silently continuing and doing wrong
    things.
    aqrln committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    576bb26 View commit details
    Browse the repository at this point in the history