Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mongodb): bring back params key to query logs #4573

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(mongodb): bring back params key to query logs #4573

merged 1 commit into from
Dec 14, 2023

Conversation

laplab
Copy link
Contributor

@laplab laplab commented Dec 14, 2023

No description provided.

@laplab laplab added this to the 5.8.0 milestone Dec 14, 2023
@laplab laplab self-assigned this Dec 14, 2023
@laplab laplab requested a review from a team as a code owner December 14, 2023 15:37
@laplab laplab requested review from miguelff and jkomyno and removed request for a team December 14, 2023 15:37
Weakky
Weakky approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link
Contributor

WASM Size

Engine This PR Base branch Diff
WASM 3.184MiB 3.184MiB 0.000B
WASM (gzip) 1.199MiB 1.199MiB -1.000B

Jolg42
Jolg42 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 14, 2023

CodSpeed Performance Report

Merging #4573 will not alter performance

Comparing fix/missing-params-key-in-mongodb-query-logs (001fcfe) with main (41b94e3)

Summary

✅ 11 untouched benchmarks

@Jolg42 Jolg42 merged commit dc5bde3 into main Dec 14, 2023
41 checks passed
@Jolg42 Jolg42 deleted the fix/missing-params-key-in-mongodb-query-logs branch December 14, 2023 16:06
This was referenced Dec 14, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@Weakky Weakky Weakky approved these changes

@miguelff miguelff Awaiting requested review from miguelff miguelff is a code owner automatically assigned from prisma/orm-rust

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

Assignees

@laplab laplab

Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laplab @Jolg42 @Weakky