Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp: Hacky way to exclude unsupported sqlite code by capabilities #4610

Closed
wants to merge 1 commit into from

Conversation

SevInf
Copy link
Member

@SevInf SevInf commented Dec 22, 2023

Do not merge

Copy link
Contributor

WASM Size

Engine This PR Base branch Diff
WASM 2.700MiB 2.719MiB -19.438KiB
WASM (gzip) 1.012MiB 1.019MiB -7.500KiB

Copy link

codspeed-hq bot commented Dec 22, 2023

CodSpeed Performance Report

Merging #4610 will improve performances by 5.03%

Comparing tmp/sqlite-only-wasm-cap (afc35d7) with tmp/sqlite-only-wasm (5d218b4)

Summary

⚡ 1 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark tmp/sqlite-only-wasm tmp/sqlite-only-wasm-cap Change
build (medium) 12.2 ms 11.6 ms +5.03%

Copy link
Contributor

✅ WASM query-engine: no benchmarks have regressed

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs

After changes in afc35d7

@SevInf SevInf closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant