Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pnpm/action-setup to v3 #4811

Merged
merged 1 commit into from
Apr 4, 2024
Merged

ci: update pnpm/action-setup to v3 #4811

merged 1 commit into from
Apr 4, 2024

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Apr 4, 2024

We can now say goodbye to the warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We can now say goodbye to the warning:
```
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: pnpm/action-setup@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```
@Jolg42 Jolg42 added this to the 5.13.0 milestone Apr 4, 2024
@Jolg42 Jolg42 requested a review from Druue April 4, 2024 16:52
@Jolg42 Jolg42 requested a review from a team as a code owner April 4, 2024 16:52
Copy link
Contributor

github-actions bot commented Apr 4, 2024

🚀 WASM query-engine performance will improve by 1.55%

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.19.1 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     410 ms/iter       (399 ms … 423 ms)    421 ms    423 ms    423 ms
Web Assembly: Latest       538 ms/iter       (524 ms … 556 ms)    548 ms    556 ms    556 ms
Web Assembly: Current      527 ms/iter       (514 ms … 541 ms)    532 ms    541 ms    541 ms
Node API: Current          237 ms/iter       (227 ms … 245 ms)    244 ms    245 ms    245 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   2.23x slower than Node API: Current
   1.29x slower than Web Assembly: Baseline
   1.02x faster than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  15'717 µs/iter (14'979 µs … 17'553 µs) 15'866 µs 17'553 µs 17'553 µs
Web Assembly: Latest    19'862 µs/iter (19'491 µs … 21'239 µs) 19'897 µs 21'239 µs 21'239 µs
Web Assembly: Current   19'432 µs/iter (18'843 µs … 19'972 µs) 19'645 µs 19'972 µs 19'972 µs
Node API: Current        8'647 µs/iter  (8'130 µs … 10'015 µs)  8'623 µs 10'015 µs 10'015 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   2.25x slower than Node API: Current
   1.24x slower than Web Assembly: Baseline
   1.02x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   2'458 µs/iter   (2'249 µs … 4'226 µs)  2'453 µs  3'920 µs  4'226 µs
Web Assembly: Latest     3'059 µs/iter   (2'853 µs … 3'940 µs)  3'089 µs  3'657 µs  3'940 µs
Web Assembly: Current    3'028 µs/iter   (2'827 µs … 5'092 µs)  3'032 µs  4'568 µs  5'092 µs
Node API: Current        1'550 µs/iter   (1'414 µs … 2'131 µs)  1'580 µs  1'892 µs  2'131 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   1.95x slower than Node API: Current
   1.23x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     688 ms/iter       (667 ms … 712 ms)    696 ms    712 ms    712 ms
Web Assembly: Latest       873 ms/iter       (858 ms … 886 ms)    886 ms    886 ms    886 ms
Web Assembly: Current      843 ms/iter       (820 ms … 860 ms)    858 ms    860 ms    860 ms
Node API: Current          602 ms/iter       (583 ms … 615 ms)    614 ms    615 ms    615 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.4x slower than Node API: Current
   1.22x slower than Web Assembly: Baseline
   1.04x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  84'339 µs/iter (82'920 µs … 85'573 µs) 85'334 µs 85'573 µs 85'573 µs
Web Assembly: Latest       114 ms/iter       (113 ms … 115 ms)    115 ms    115 ms    115 ms
Web Assembly: Current      113 ms/iter       (111 ms … 115 ms)    114 ms    115 ms    115 ms
Node API: Current       68'933 µs/iter (68'117 µs … 70'215 µs) 70'025 µs 70'215 µs 70'215 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.64x slower than Node API: Current
   1.34x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'243 ms/iter   (1'186 ms … 1'290 ms)  1'268 ms  1'290 ms  1'290 ms
Web Assembly: Latest     1'566 ms/iter   (1'552 ms … 1'577 ms)  1'577 ms  1'577 ms  1'577 ms
Web Assembly: Current    1'548 ms/iter   (1'513 ms … 1'586 ms)  1'569 ms  1'586 ms  1'586 ms
Node API: Current        1'205 ms/iter   (1'158 ms … 1'245 ms)  1'242 ms  1'245 ms  1'245 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.28x slower than Node API: Current
   1.25x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     161 ms/iter       (155 ms … 165 ms)    164 ms    165 ms    165 ms
Web Assembly: Latest       193 ms/iter       (189 ms … 199 ms)    196 ms    199 ms    199 ms
Web Assembly: Current      189 ms/iter       (185 ms … 193 ms)    190 ms    193 ms    193 ms
Node API: Current          128 ms/iter       (120 ms … 134 ms)    133 ms    134 ms    134 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.47x slower than Node API: Current
   1.17x slower than Web Assembly: Baseline
   1.03x faster than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'111 µs/iter     (993 µs … 1'909 µs)  1'112 µs  1'709 µs  1'909 µs
Web Assembly: Latest     1'461 µs/iter   (1'343 µs … 2'235 µs)  1'467 µs  1'955 µs  2'235 µs
Web Assembly: Current    1'454 µs/iter   (1'334 µs … 2'275 µs)  1'453 µs  2'009 µs  2'275 µs
Node API: Current          861 µs/iter     (790 µs … 1'588 µs)    875 µs  1'178 µs  1'588 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.69x slower than Node API: Current
   1.31x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'099 µs/iter   (1'014 µs … 1'941 µs)  1'105 µs  1'454 µs  1'941 µs
Web Assembly: Latest     1'458 µs/iter   (1'370 µs … 2'236 µs)  1'462 µs  2'111 µs  2'236 µs
Web Assembly: Current    1'457 µs/iter   (1'371 µs … 2'131 µs)  1'475 µs  1'671 µs  2'131 µs
Node API: Current          863 µs/iter     (797 µs … 1'231 µs)    882 µs    956 µs  1'231 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.69x slower than Node API: Current
   1.33x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

After changes in cbf5c2e

@Jolg42
Copy link
Contributor Author

Jolg42 commented Apr 4, 2024

Since it's working as expected, I will merge this now already.

@Jolg42 Jolg42 merged commit 3d92748 into main Apr 4, 2024
4 checks passed
@Jolg42 Jolg42 deleted the joel/pnpm-action-setup branch April 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant