feat: complete format support #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM Query Engine file Size
|
✅ WASM query-engine performance won't change substantially (1.005x)Full benchmark reportAfter changes in be1faff |
jkomyno
commented
Apr 10, 2024
| @@ -1,6 +1,6 @@ | |||
| mod actions; | |||
| mod format; | |||
| mod lint; | |||
| // mod lint; | |||
There was a problem hiding this comment.
Changes to main.rs are necessary to let prisma-fmt compile.
I commented out the prisma-fmt lint command keeping in mind that, with https://github.com/prisma/team-orm/issues/1100, we will soon get rid of prisma-fmt's binary anyway
jkomyno
commented
Apr 10, 2024
Comment on lines
+11
to
+19
| impl<'de> Deserialize<'de> for SourceFile { | ||
| fn deserialize<D>(deserializer: D) -> Result<Self, D::Error> | ||
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| let s: String = serde::de::Deserialize::deserialize(deserializer)?; | ||
| Ok(s.into()) | ||
| } | ||
| } |
There was a problem hiding this comment.
This allows deriving Multiple(Vec<(String, SourceFile)>) from Vec<(String, String)> within the following:
#[derive(Deserialize, Debug)]
#[serde(untagged)]
pub(crate) enum SchemaFileInput {
Single(String),
Multiple(Vec<(String, SourceFile)>),
}It also highlights that SourceFile is created from a String.
There was a problem hiding this comment.
Nice!
Wouldn't putting #[serde(transparent)] over SourceFile do the same?
There was a problem hiding this comment.
Afaik it wouldn't be the same, as SourceFile is essentially a newtype over a Contents field, not a String field
jkomyno
requested review from
laplab and
SevInf
and removed request for
a team and
laplab
CodSpeed Performance ReportMerging #4818 will not alter performanceComparing Summary
|
Weakky
approved these changes
Apr 10, 2024
SevInf
reviewed
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes https://github.com/prisma/team-orm/issues/1097. It enables https://github.com/prisma/team-orm/issues/1096.
/integration