prisma-fmt: Make get_config error tolerant
#4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevInf
commented
May 17, 2024
CodSpeed Performance ReportMerging #4875 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
SevInf
force-pushed
the
get-config-fault-tolerant
branch
from
7f06c79
to
f99e7a8
Compare
SevInf
commented
May 17, 2024
🚀 WASM query-engine performance will improve by 2.44%Full benchmark reportAfter changes in 49eaa97 |
SevInf
force-pushed
the
get-config-fault-tolerant
branch
from
52596dc
to
6ddcfcd
Compare
SevInf
changed the title
parse_confgiration_multi error tolerantget_config error tolerant
jkomyno
reviewed
May 28, 2024
jkomyno
reviewed
May 28, 2024
jkomyno
reviewed
May 28, 2024
Druue
reviewed
May 28, 2024
psl/psl/src/lib.rs
Outdated
| /// blocks. It never fails, but when the returned `Diagnostics` contains errors, it implies that the | ||
| /// `Configuration` content is partial. | ||
| /// Consumers may then decide whether to convert `Diagnostics` into an error. | ||
| pub fn infallible_parse_configuration(files: &[(String, SourceFile)]) -> (Files, Configuration, Diagnostics) { |
There was a problem hiding this comment.
I keep getting confused by this being called infallible and thinking ah, yes, no issues at all, wait, why are we getting diagnostics, what happened to our infallible leader!?
There was a problem hiding this comment.
@SevInf, maybe parse_config_best_effort could better emphasise the role of this function?
jkomyno
approved these changes
May 28, 2024
Druue
approved these changes
May 28, 2024
Now the function never fails and always returns both `Config` and `Diagnostics`. In case of errors, `Diagnostic` would be non-empty, but it will still try to return as much of a config as it was able to parse. This is useful mostly for dev tools - they need to be able to read preview feature from more invalid files than old `get_config` would've allowed. It also improves diagnostics in the CLI since we are now also able to tell that user wanted to have more cases. This is a breaking change to consumers of `prisma-fmt`: both prisma cli and language-tools would need to be adapted to the new signature. Contributes to prisma/team-orm#1143 Contributes to prisma/team-orm#1127 (opportunistic refactor)
SevInf
force-pushed
the
get-config-fault-tolerant
branch
from
49eaa97
to
033c2c5
Compare
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
May 30, 2024
Integrates prisma/prisma-engines#4875. Adapts `get_config` to changes from internals. Closes prisma/team-orm#1143
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
May 30, 2024
Integrates prisma/prisma-engines#4875. Adapts `get_config` to changes from internals. Closes prisma/team-orm#1143
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
May 30, 2024
Integrates prisma/prisma-engines#4875. Adapts `get_config` to changes from internals. Closes prisma/team-orm#1143
SevInf
added a commit
to prisma/prisma
that referenced
this pull request
May 30, 2024
…24349) * feat(schema-files-loader): Read preview feature from invalid schemas Integrates prisma/prisma-engines#4875. Adapts `get_config` to changes from internals. Closes prisma/team-orm#1143 * Bump engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new function
infallible_parse_configurationthat never fails and always returns bothConfigandDiagnostics. In case of errors,Diagnosticwould be non-empty, butit will still try to return as much of a config as it was able to parse.
This is useful mostly for dev tools - they need to be able to read
preview feature from more invalid files than old
get_configwould'veallowed. It also improves diagnostics in the CLI since we are now also
able to tell that user wanted to have more cases.
This is a breaking change to consumers of
prisma-fmt: both prisma cliand language-tools would need to be adapted to the new signature.
Contributes to prisma/team-orm#1143
Contributes to prisma/team-orm#1127 (opportunistic refactor)