Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UUIDv7 #4877

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

mcuelenaere
Copy link

@mcuelenaere mcuelenaere commented May 20, 2024

This implements prisma/prisma#24079. The change is pretty minimal, widening the support from @default(uuid()) to @default(uuid(7)).

It leverages the existing uuid crate instead of adding a new one (uuid7).

Right now this code is mostly untested (apart from the tests I added to psl), because I couldn't get the tests running locally. I'd appreciate some guidance in this area. CI runs fine

@mcuelenaere mcuelenaere requested a review from a team as a code owner May 20, 2024 12:14
@mcuelenaere mcuelenaere requested review from jkomyno and removed request for a team May 20, 2024 12:14
@CLAassistant
Copy link

CLAassistant commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

@kibertoad
Copy link

uuid seems to be behind uuid7 with regards to how accurately it represents the spec. See discussion here: uuid-rs/uuid#717

@SevInf SevInf removed the request for review from jkomyno May 21, 2024 08:36
Copy link

codspeed-hq bot commented May 21, 2024

CodSpeed Performance Report

Merging #4877 will not alter performance

Comparing mcuelenaere:feature/uuidv7 (63c787e) with main (b4fe3e6)

Summary

✅ 11 untouched benchmarks

@mcuelenaere
Copy link
Author

FYI: after this gets an approval, I'll rebase + squash the fixup commits

@kibertoad
Copy link

@Weakky Gentle ping. Is anything missing in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants