-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UUIDv7 #4877
Open
mcuelenaere
wants to merge
10
commits into
prisma:main
Choose a base branch
from
mcuelenaere:feature/uuidv7
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for UUIDv7 #4877
+134
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CodSpeed Performance ReportMerging #4877 will not alter performanceComparing Summary
|
f5d661e
to
46047f6
Compare
FYI: after this gets an approval, I'll rebase + squash the fixup commits |
@Weakky Gentle ping. Is anything missing in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements prisma/prisma#24079. The change is pretty minimal, widening the support from
@default(uuid())
to@default(uuid(7))
.It leverages the existing
uuid
crate instead of adding a new one (uuid7
).Right now this code is mostly untested (apart from the tests I added toCI runs finepsl
), because I couldn't get the tests running locally. I'd appreciate some guidance in this area.