Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp: use branch with disabled driver adapters #4904

Closed
wants to merge 1 commit into from
Closed

temp: use branch with disabled driver adapters #4904

wants to merge 1 commit into from

Conversation

janpio
Copy link
Member

@janpio janpio commented Jun 3, 2024

DRIVER_ADAPTERS_BRANCH=janpio/disable-driver-adapters

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #4904 will not alter performance

Comparing janpio/disable-driver-adapters (af70737) with main (7320bfa)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.043MiB 2.043MiB 0.000B
Postgres (gzip) 813.867KiB 813.868KiB -1.000B
Mysql 2.013MiB 2.013MiB 0.000B
Mysql (gzip) 800.250KiB 800.252KiB -2.000B
Sqlite 1.914MiB 1.914MiB 0.000B
Sqlite (gzip) 762.106KiB 762.109KiB -3.000B

@janpio
Copy link
Member Author

janpio commented Jun 3, 2024

Does not actually use LibraryEngine, only DriverAdapters.

@janpio janpio closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@janpio