feat(query-engine-c-abi): add Mac Catalyst support #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Mac Catalyst target to `query-engine-c-abi`. Because the target is a [Tier 3 platform for Rust](https://doc.rust-lang.org/nightly/rustc/platform-support.html#tier-3), we have to compile the `std` crate ourselves, so we also need the nightly Rust compiler.
…uilds This is so that we can build for React Native without the metrics altogether. The libraries used by `query-engine-metrics` seem to have multiple versions installed as-per the Cargo lockfile, and strangely the issue only manifests itself when building for the Mac Catalyst target.
|
|
CodSpeed Performance ReportMerging #4913 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits.
The first commit adds a Mac Catalyst target to
query-engine-c-abi. Because the target is a Tier 3 platform for Rust, we have to compile thestdcrate ourselves, so we also need the nightly Rust compiler.In an ideal world, the first commit would've been enough, however I had to make a second commit which does some horrible things to
query-engine-commonandquery-engine-metricsto disable metrics forquery-engine-c-abi. The libraries used byquery-engine-metricsseem to have multiple versions installed according to the Cargo lockfile, and strangely the issue only manifests itself when building for the Mac Catalyst (aarch64-apple-ios-macabi) target.I'm not a Rust expert by any means, and I am aware Tier 3 platforms might not be something @prisma is interested in, but if anyone with more knowledge could take a look and offer some advice, I'd be most appreciative 😀
In the meantime, this branch does successfully build an
.xcframeworkfile forquery-engine-c-abion the Mac Catalyst platform and I have managed to successfully build and boot my Expo Mac Catalyst application, so I'm leaving this PR as a draft for anyone else that might want to do the same./cc @SevInf @sorenbs @ospfranco