fix: support 1-m relevance ordering #4915
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4915 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Weakky
commented
Jun 11, 2024
| let parent_alias = self.parent_alias.clone(); | ||
| let joins: Vec<AliasedJoin> = self.compute_one2m_join(&order_by.path, parent_alias.as_ref(), ctx); |
There was a problem hiding this comment.
Relations weren't taken into account at all. We're now gathering the path (which is an array of relation fields) that leads to the fields we try to order by on. We compute the needed joins, and then we order by the last field, aliased by the last join alias. This is the same process as regular relational ordering on scalar field.
|
You're an absolute hero |
Weakky
commented
Jun 20, 2024
| @@ -376,6 +376,92 @@ async fn on_many_fields_with_aggr_and_pagination(runner: Runner) -> TestResult<( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| async fn on_1m_relation_field(runner: Runner) -> TestResult<()> { | |||
There was a problem hiding this comment.
add tests where we hop through several to-one relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes prisma/prisma#17428
fixes prisma/prisma#21107