Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement escaping and unescaping of special characters in string literals across connectors #738

Merged
merged 6 commits into from
May 14, 2020
Merged

Implement escaping and unescaping of special characters in string literals across connectors #738

merged 6 commits into from
May 14, 2020

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented May 7, 2020 •
edited

Restructuring of #733 into a cleaner commit history.

Addresses #691
Closes prisma/prisma#1888

Blocked on prisma/quaint#130

@tomhoule tomhoule added tech/engines/migration engine Issue in the Migration Engine tech/engines/introspection engine Issue in the Introspection Engine tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema labels May 7, 2020
@tomhoule tomhoule added this to the Beta 5 milestone May 7, 2020
@tomhoule
Copy link
Contributor Author

Reminder: update https://github.com/prisma/specs/issues/466 once this is merged.

@janpio janpio modified the milestones: Beta 5, Beta 6 May 12, 2020
@tomhoule
Copy link
Contributor Author

Things that were decided during review with @do4gr

  • Do the godzilla roundtrip test in the schema parser too
  • Write tests for the case of the issue linked in the description

First point is done, started on the second one, but it will need non-test changes too.

@tomhoule tomhoule merged commit 69a699b into master May 14, 2020
@tomhoule tomhoule deleted the string-literals-escaping branch May 14, 2020 15:42
@tomhoule tomhoule mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine
Projects
None yet
Milestone
Beta 6
Development

Successfully merging this pull request may close these issues.

Introspect default value with backslashes causes problem when generating client
2 participants
@tomhoule @janpio