Improve Postgres Enum Default Recognition #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
lgtm! I haven't re-checked these, but I was just wondering whether we already had a regular expression in that module that we use to match casts, quoted or unquoted. That way we could use it to do a replace and avoid the if <matches this> { replace this } else if <matches that> { replace that }.
|
We have one for datatype suffixes, but in this case we need to check against all the enum names in the schema, so that one does not directly apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes prisma/prisma#2689