Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback not triggered in an interactive transaction when connection limit is high #10622

Closed
AoiIsMine opened this issue Dec 8, 2021 · 2 comments · Fixed by #10797
Closed

Rollback not triggered in an interactive transaction when connection limit is high #10622

AoiIsMine opened this issue Dec 8, 2021 · 2 comments · Fixed by #10797
Assignees
@millsp
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: interactiveTransactions

Comments

@AoiIsMine
Copy link

AoiIsMine commented Dec 8, 2021 •
edited

Bug description

I try to execute multiple interactive transactions concurrently and find that when the number of connections is high, throwing an error will not trigger transaction rollback
When the number of connections is small, although there will be errors, it can still be rolled back
(on another computer, connections 5 (CPU is 2) ,can be rolled back without an error.)

I'm not sure what caused it or whether it can be reproduced on other computers

How to reproduce

code demo

Environment & setup

  • OS: Windows,
  • Database: MySQL 8.0
  • Node.js version: v14.16.0

Prisma Version

3.6.0
@AoiIsMine AoiIsMine added the kind/bug A reported bug. label Dec 8, 2021
@janpio janpio added topic: interactiveTransactions bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. labels Dec 8, 2021
@AoiIsMine
Copy link
Author

i use knex.js is will success, can rollback

@pantharshit00 pantharshit00 changed the title When multiple interactive transactions are executed concurrently, throw error ,no triggering transaction rollback Rollback not triggered in an interactive transaction when connection limit is high Dec 13, 2021
@pantharshit00
Copy link
Contributor

Thanks for the issue. I can reproduce this.

@pantharshit00 pantharshit00 added bug/2-confirmed Bug has been reproduced and confirmed. team/client Issue for team Client. and removed bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. labels Dec 13, 2021
@millsp millsp self-assigned this Jan 13, 2022
@millsp millsp linked a pull request Jan 13, 2022 that will close this issue
fix(client): rethrow error for tx #10797
Merged
@millsp millsp mentioned this issue Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millsp millsp

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: interactiveTransactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client): rethrow error for tx prisma/prisma
5 participants
@matthewmueller @janpio @millsp @pantharshit00 @AoiIsMine