Snapshot serializer in CLI tests doesn't replace time durations >= 1s with a placeholder

[aqrln]

Snapshot serializer in CLI tests doesn't replace time durations greater than or equal to 1s with a placeholder.

Failed pipeline: https://github.com/prisma/prisma/runs/4657927865?check_suite_focus=true#step:15:662

  ● --schema from parent directory › --schema absolute path: should work

    expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `--schema from parent directory --schema absolute path: should work 1`

    - Snapshot  - 1
    + Received  + 1

      ↵
    - ✔ Generated Prisma Client (0.0.0 | TEST_ENGINE_TYPE) to ./subdirectory/@prisma/client in XXms
    + ✔ Generated Prisma Client (0.0.0 | TEST_ENGINE_TYPE) to ./subdirectory/@prisma/client in 3.34s
      You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client

Relevant code:

prisma/packages/cli/src/__tests__/__helpers__/snapshotSerializer.ts

Lines 37 to 39 in c1fdadf

	function normalizeMs(str) {
	return str.replace(/\d{1,3}ms/g, 'XXms')
	}

[Jolg42]

It does now so I'll close

https://github.com/prisma/prisma/blob/main/packages/sdk/src/utils/jestSnapshotSerializer.js#L74

[aqrln]

Thanks!

[aqrln]

prisma/packages/sdk/src/utils/jestSnapshotSerializer.js

Line 74 in 7aba6a3

return str.replace(/ \d+ms/g, ' XXXms').replace(/ \d+(.\d+)?s/g, ' XXXms')

. needs to be escaped here

> / \d+(.\d+)?s/.test(' 3a3s')
true

[Jolg42]

Thanks! added in #11123