Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --preview-feature flag for Primitives (migrate diff and db execute) #12679

Closed
Tracked by #12136
janpio opened this issue Apr 5, 2022 · 1 comment · Fixed by #12832
Closed
Tracked by #12136

Remove --preview-feature flag for Primitives (migrate diff and db execute) #12679

janpio opened this issue Apr 5, 2022 · 1 comment · Fixed by #12832
Assignees
@jkomyno
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: prisma db execute CLI: prisma db execute topic: prisma migrate diff CLI: prisma migrate diff
Milestone
3.13.0

Comments

@janpio
Copy link
Member

janpio commented Apr 5, 2022 •
edited by Jolg42

... from commands and CLI help output.

Note: Not only the --preview-feature needs to be removed, also the "Preview" mentions about these commands in help outputs for example.

Final step of #12136
@janpio janpio added kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: prisma db execute CLI: prisma db execute topic: prisma migrate diff CLI: prisma migrate diff labels Apr 5, 2022
@janpio janpio mentioned this issue Apr 5, 2022
Closed
23 tasks
@janpio janpio added this to the 3.13.0 milestone Apr 11, 2022
@Jolg42 Jolg42 changed the title Remove --preview-flag for Primitives (migrate diff and db execute) Remove --preview-feature flag for Primitives (migrate diff and db execute) Apr 12, 2022
@Jolg42
Copy link
Member

Jolg42 commented Apr 12, 2022 •
edited

We should make this change not breaking: meaning if a user pass the --preview-feature in the new version, it should not error.
It could warn that the flag is not needed and can be removed

@jkomyno jkomyno mentioned this issue Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkomyno jkomyno

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: prisma db execute CLI: prisma db execute topic: prisma migrate diff CLI: prisma migrate diff
Projects
None yet
Milestone
3.13.0
Development

Successfully merging a pull request may close this issue.

chore(migrate): remove --preview-feature flag from "migrate diff" and "db execute" prisma/prisma
3 participants
@janpio @Jolg42 @jkomyno