Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the feature to “Prisma relation mode” → relationMode #15601

Closed
7 tasks done
Tracked by #11441
Jolg42 opened this issue Sep 29, 2022 · 2 comments
Closed
7 tasks done
Tracked by #11441

Rename the feature to “Prisma relation mode” → relationMode #15601

Jolg42 opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: referentialIntegrity/relationMode
Milestone

Comments

@Jolg42
Copy link
Member

Jolg42 commented Sep 29, 2022

See details https://www.notion.so/prismaio/How-do-we-GA-the-referentialIntegrity-preview-feature-8a656fe445ae4a69ad19c5000e5c7191#72322949b0ab4343a63b6c39e4d61f19

Plan

Note: we want to ensure backward-compatibility!

  • UNDO Move referentialIntegrity to the hidden feature flags, add relationMode to the active feature flags (see preview_features.rs)
  • Check that referentialIntegrity is still supported as a preview feature and works as before
  • Check that relationMode is supported as a preview feature and works as referentialIntegrity did before
  • Rename references of referentialIntegrity=prisma/foreignKeys to relationMode
    • In prisma/prisma-engines
    • In prisma/prisma
    • In prisma/language-tools (nothing to rename)

Contributing PRs

@Jolg42 Jolg42 mentioned this issue Sep 29, 2022
35 tasks
@Jolg42 Jolg42 added this to the 4.5.0 milestone Sep 29, 2022
@Jolg42 Jolg42 added team/schema Issue for team Schema. topic: referentialIntegrity/relationMode tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. labels Sep 29, 2022
@millsp millsp added the kind/improvement An improvement to existing feature and code. label Sep 30, 2022
@Jolg42
Copy link
Member Author

Jolg42 commented Oct 5, 2022

@jkomyno We need to undo the preview feature flag renaming, it's not needed and makes things more complicated in the end.

@Jolg42
Copy link
Member Author

Jolg42 commented Oct 5, 2022

Undo was done in prisma/prisma-engines#3263

And renaming was done in the tests PR #14221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: referentialIntegrity/relationMode
Projects
None yet
Development

No branches or pull requests

3 participants