Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all glibc Linux binaries with CentOS 7 #16772

Closed
pimeys opened this issue Dec 13, 2022 · 1 comment · Fixed by prisma/prisma-engines#3952
Closed

Build all glibc Linux binaries with CentOS 7 #16772

pimeys opened this issue Dec 13, 2022 · 1 comment · Fixed by prisma/prisma-engines#3952
Assignees
Milestone

Comments

@pimeys
Copy link
Contributor

pimeys commented Dec 13, 2022

Jessie is out of support and broken, we cannot really update it anymore and it's blocking rust updates for the build images.

Internal document: https://www.notion.so/prismaio/Debian-Build-Images-0c6a18c670ad47898a8ef1fbebd80e28

Luckily we can build with CentOS 7, and the binaries will work in all Linux distros with glibc version of at least 2.17, meaning the binaries created on CentOS 7 will work on old Debian and Ubuntu distros just fine.

We want to do this after the holidays, tasks:

  • Make sure Migration Engine can vendor OpenSSL similarly the same way as Query Engine and Introspection Engine does.
  • First remove the Debian builds, copy the binaries generated with CentOS 7 to two places: RHEL and Debian.

LATER, maybe

  • Cut down the needed binaries, we don't need to store debian binaries separately
  • Rename rhel-openssl-1.0 et.al. to glibc-2.17-openssl-1.0.
  • Change how the download logic works, so it uses the new names correctly.
@aqrln
Copy link
Member

aqrln commented May 5, 2023

Created a new issue for the follow-up breaking change in Prisma 5: https://github.com/prisma/team-orm/issues/128

@Jolg42 Jolg42 added this to the 4.14.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants