Lock Engines' Git Dependencies to Specific Commits #18150
Labels
kind/tech
A technical change.
team/client
Issue for team Client.
team/schema
Issue for team Schema.
tech/engines/migration engine
Issue in the Migration Engine
tech/engines/query engine
Issue in the Query Engine
Problem
Engine dependencies like
quaint
andmysql_async
are currently referred to by branch names, but this results in breaking changes being propagated to Prisma Client Rust even though I already lock to specific commits of the engines. Recently PCR's MySQL support has broken becausemysql_async
received a breaking update -quaint
depends onmysql_async
via branch, so when Cargo resolvesquaint
's dependencies it just uses the latest - and incomaptible - version ofmysql_async
.Suggested solution
Use
rev = "..."
instead ofbranch = "..."
when specifying git dependencies in the engines.Alternatives
I just keep forking and maintaining stable versions of each engine dependency.
Additional context
First discussed in #collab-custom-prisma-clients in Slack.
Would fix Brendonovich/prisma-client-rust#256
The text was updated successfully, but these errors were encountered: