Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Engines' Git Dependencies to Specific Commits #18150

Open
Brendonovich opened this issue Mar 1, 2023 · 0 comments
Open

Lock Engines' Git Dependencies to Specific Commits #18150

Brendonovich opened this issue Mar 1, 2023 · 0 comments
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine

Comments

@Brendonovich
Copy link

Brendonovich commented Mar 1, 2023

Problem

Engine dependencies like quaint and mysql_async are currently referred to by branch names, but this results in breaking changes being propagated to Prisma Client Rust even though I already lock to specific commits of the engines. Recently PCR's MySQL support has broken because mysql_async received a breaking update - quaint depends on mysql_async via branch, so when Cargo resolves quaint's dependencies it just uses the latest - and incomaptible - version of mysql_async.

Suggested solution

Use rev = "..." instead of branch = "..." when specifying git dependencies in the engines.

Alternatives

I just keep forking and maintaining stable versions of each engine dependency.

Additional context

First discussed in #collab-custom-prisma-clients in Slack.
Would fix Brendonovich/prisma-client-rust#256

@janpio janpio added kind/tech A technical change. tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine team/schema Issue for team Schema. team/client Issue for team Client. labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/engines/migration engine Issue in the Migration Engine tech/engines/query engine Issue in the Query Engine
Projects
None yet
Development

No branches or pull requests

2 participants