Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD 14 as a new platform #22228

Closed
tinola opened this issue Dec 3, 2023 · 2 comments · Fixed by #22300
Closed

Add FreeBSD 14 as a new platform #22228

tinola opened this issue Dec 3, 2023 · 2 comments · Fixed by #22300

Comments

@tinola
Copy link
Contributor

tinola commented Dec 3, 2023

Bug description

After upgrade to FreeBSD 14-RELEASE I can build new engines, but client is failing:

PrismaClientInitializationError: Unknown PRISMA_QUERY_ENGINE_LIBRARY freebsd14

or

Error: Unknown binary target freebsd14 in generator client.

How to reproduce

Expected behavior

Please add "freebsd14" string to those files:

packages/fetch-engine/src/download.ts
packages/get-platform/src/getPlatform.ts
packages/get-platform/src/platforms.ts

Prisma information

Environment & setup

  • OS: FreeBSD 14-RELEASE
  • Database: PostgreSQL
  • Node.js version: v18.18.2

Prisma Version

5.5.2
@tinola tinola added the kind/bug A reported bug. label Dec 3, 2023
@aqrln aqrln added kind/feature A request for a new feature. topic: deployment-platform topic: freebsd team/client Issue for team Client. topic: binaryTargets and removed kind/bug A reported bug. labels Dec 5, 2023
@aqrln
Copy link
Member

aqrln commented Dec 6, 2023

Thanks for the issue @tinola, would you mind opening a quick a PR? I think it probably just needs to be added in these places:

@tinola
Copy link
Contributor Author

tinola commented Dec 7, 2023

Hi, I've created https://github.com/prisma/prisma/pull/22300.

I'd like to test, but I don't know how to do it.
prisma is one of many dependencies of https://github.com/sinamics/ztnet project, so I think prisma client is downloading during npm build process straight from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants