Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview feature feedback: insensitiveFilters #3340

Closed
nikolasburk opened this issue Aug 18, 2020 · 7 comments
Closed

Preview feature feedback: insensitiveFilters #3340

nikolasburk opened this issue Aug 18, 2020 · 7 comments
Labels
kind/feedback Issue for gathering feedback. topic: previewFeatures Issue touches on an preview feature flag
Milestone

Comments

@nikolasburk
Copy link
Member

Please share your feedback about the preview feature insensitiveFilters that was released in v2.5.0 in this issue.

  • If you encounter a bug, please open a bug report in this repo.
  • If the feature is working well for you, please share this in a comment below or leave a 👍 on this issue.

If you have any questions, don't hesitate to ask them in the #prisma2 channel in the Prisma Slack.

@timleslie
Copy link

This feature is working exactly how I would want it to, thanks! 🙏

@saraveti
Copy link

@nikolasburk - As per Preview Feature documentation here , it says that it is only supported for ProstgreSQL.
Is there a plan to support this for MariaDB, in near feature.

@dpetrick
Copy link
Contributor

@saraveti The reason it's only on postgres is that there's no reason to implement it on MySQL-based databases - they're already case insensitive by default in the vast majority of use cases.

@saraveti
Copy link

@saraveti The reason it's only on postgres is that there's no reason to implement it on MySQL-based databases - they're already case insensitive by default in the vast majority of use cases.

@dpetrick . Thanks for providing the response. I did verify the case insensitive search with Prisma & MariaDB. Its working. Thanks again.

@heibel
Copy link

heibel commented Sep 25, 2020

This works perfect! Am using it with nexus.

...
where: {
  OR: [
    { name: { contains: "{keyword}", mode: QueryMode.Insensitive } },
    { city: { contains: "{keyword}", mode: QueryMode.Insensitive } },
  ],
},

@nikolasburk
Copy link
Member Author

Thank you so much for the feedback everyone!

Thanks to this, we were able to promote case insensitive filters to stable in today's release 🥳

@Jolg42 Jolg42 added this to the Release 2.8.0 milestone Sep 29, 2020
@Noitidart
Copy link

Is this possible with json filter?

    prisma.subscription.findMany({
      where: {
        attrs: {
          path: ['customer', 'email'],
          equals: email,
          mode: 'insensitive'
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feedback Issue for gathering feedback. topic: previewFeatures Issue touches on an preview feature flag
Projects
None yet
Development

No branches or pull requests

8 participants