Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report the database version in the migrate/introspection error reports #3486

Closed
pantharshit00 opened this issue Sep 1, 2020 · 2 comments
Closed

Report the database version in the migrate/introspection error reports #3486

pantharshit00 opened this issue Sep 1, 2020 · 2 comments
Assignees
@Jolg42 @do4gr
Labels
kind/feature A request for a new feature. tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: error reporting Issues created via Prisma's CLI Crash Reporting
Milestone
Release 2.10.0

Comments

@pantharshit00
Copy link
Contributor

pantharshit00 commented Sep 1, 2020 •
edited

Please see: https://github.com/prisma/error-reporting-gui/issues/28

Right now we don't collect this information in the error reports but the database version information can be very useful for figuring out what happened. This mostly likely will need some engines work, cli work and changed on the error handling backend.

This issue aims on kickstarting that process.
@pantharshit00 pantharshit00 added kind/feature A request for a new feature. topic: error reporting Issues created via Prisma's CLI Crash Reporting process/candidate labels Sep 1, 2020
@janpio janpio added tech/engines Issue for tech Engines. size/S tech/typescript Issue for tech TypeScript. labels Sep 1, 2020
@janpio
Copy link
Member

janpio commented Sep 1, 2020

Initial conversation showed that we have similar information available in quaint already, so exposing this would just be a question of creating an RPC for it and then calling that during the error report generation.

@janpio janpio added this to the Backlog 2.7.0 milestone Sep 2, 2020
@mavilein mavilein added tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine labels Sep 3, 2020
@do4gr do4gr mentioned this issue Sep 11, 2020
Merged
@janpio janpio modified the milestones: Backlog 2.7.0, Backlog 2.8.0 Sep 16, 2020
@Jolg42 Jolg42 mentioned this issue Sep 29, 2020
Merged
@janpio janpio modified the milestones: Backlog 2.8.0, Backlog 2.9.0 Sep 29, 2020
@janpio janpio modified the milestones: Backlog 2.9.0, Backlog 2.10.0 Oct 14, 2020
@Jolg42 Jolg42 modified the milestones: Backlog 2.10.0, Release 2.10.0 Oct 27, 2020
@Jolg42 Jolg42 closed this as completed Oct 27, 2020
@Jolg42
Copy link
Member

Jolg42 commented Oct 27, 2020

Done, needs to happen in prisma/error-reporting-gui#28 for the UI

@Jolg42 Jolg42 mentioned this issue Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

@do4gr do4gr

Labels
kind/feature A request for a new feature. tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: error reporting Issues created via Prisma's CLI Crash Reporting
Projects
None yet
Milestone
Release 2.10.0
Development

No branches or pull requests
6 participants
@matthewmueller @janpio @Jolg42 @mavilein @do4gr @pantharshit00