Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript version check #5728

Closed
timsuchanek opened this issue Feb 18, 2021 · 2 comments · Fixed by #6060 or #7843
Closed

Add TypeScript version check #5728

timsuchanek opened this issue Feb 18, 2021 · 2 comments · Fixed by #6060 or #7843
Assignees
@timsuchanek @williamluke4
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: dx
Milestone
2.26.0

Comments

@timsuchanek
Copy link
Contributor

We need at least TypeScript 4.1 to run @prisma/client. This should be enforced to prevent bad surprises.
@timsuchanek timsuchanek added tech/typescript Issue for tech TypeScript. team/client Issue for team Client. labels Feb 18, 2021
@janpio janpio mentioned this issue Feb 18, 2021
Closed
@Jolg42 Jolg42 mentioned this issue Feb 19, 2021
Closed
@matthewmueller matthewmueller added this to the 2.19.0 milestone Mar 3, 2021
@williamluke4 williamluke4 mentioned this issue Mar 11, 2021
Merged
@realSaddy
Copy link

realSaddy commented May 24, 2021 •
edited

This warning did not appear for me when my global typescript was ^4.1, but my local typescript was not. Silly mistake on my side, but it is something that could be improved if possible.

// EDIT
As a note, I launch my code through package.json scripts.

@janpio janpio reopened this May 25, 2021
@pantharshit00
Copy link
Contributor

I can reproduce this. There was no warning thrown when I had 3.9.9 locally

@janpio janpio added kind/feature A request for a new feature. bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. topic: dx and removed kind/feature A request for a new feature. labels May 26, 2021
@pantharshit00 pantharshit00 mentioned this issue May 27, 2021
Closed
@williamluke4 williamluke4 mentioned this issue Jun 24, 2021
Merged
@Jolg42 Jolg42 modified the milestones: 2.19.0, 2.26.0 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timsuchanek timsuchanek

@williamluke4 williamluke4

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: dx
Projects
None yet
Milestone
2.26.0
7 participants
@matthewmueller @janpio @timsuchanek @Jolg42 @williamluke4 @pantharshit00 @realSaddy