Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-index.d.ts is outdated #6500

Open
janpio opened this issue Apr 10, 2021 · 8 comments
Open

default-index.d.ts is outdated #6500

janpio opened this issue Apr 10, 2021 · 8 comments
Labels
kind/tech A technical change. team/client Issue for team Client. topic: prisma-client

Comments

@janpio
Copy link
Member

janpio commented Apr 10, 2021

https://github.com/prisma/prisma/blob/master/src/packages/client/scripts/default-index.d.ts is outdated in comparison to the fully generated version:

  • Code example in docs comment
  • Documentation link in docs comment
  • Possibly missing namespace for property dmmf?
  • Line breaks for PromiseType and PromiseReturnType

Found via comparing node_modules\.prisma\client\index.d.ts in a project before and after generating a Client the first time.

@janpio janpio added topic: prisma-client kind/tech A technical change. team/client Issue for team Client. labels Apr 10, 2021
@jasonsilvers

This comment has been minimized.

@pantharshit00

This comment has been minimized.

@janpio

This comment has been minimized.

@jasonsilvers

This comment has been minimized.

@janpio

This comment has been minimized.

@kiily

This comment has been minimized.

@pantharshit00
Copy link
Contributor

@janpio Is this still relevant?

@janpio
Copy link
Member Author

janpio commented Aug 2, 2021

Yes, someone from the Client TS team needs to take a look at the generated vs. the stub version and confirm they are identical/equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. topic: prisma-client
Projects
None yet
Development

No branches or pull requests

4 participants