Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referentialActions: Only underline offending part of line when using referential actions, but not having preview feature enabled #7947

Closed
janpio opened this issue Jun 29, 2021 · 2 comments · Fixed by prisma/prisma-engines#2064
Closed

referentialActions: Only underline offending part of line when using referential actions, but not having preview feature enabled #7947

janpio opened this issue Jun 29, 2021 · 2 comments · Fixed by prisma/prisma-engines#2064
Assignees
@pimeys @tomhoule
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: referential actions topic: schema validation topic: schema
Milestone
2.27.0

Comments

@janpio
Copy link
Member

janpio commented Jun 29, 2021

image
it could only give a red squiggly line to the invalid part of the line
@tomhoule tomhoule transferred this issue from prisma/language-tools Jun 30, 2021
@tomhoule tomhoule added tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema team/schema Issue for team Schema. topic: referential actions topic: schema topic: schema validation labels Jun 30, 2021
@tomhoule tomhoule assigned tomhoule and pimeys and unassigned tomhoule Jun 30, 2021
@tomhoule tomhoule added this to the 2.27.0 milestone Jun 30, 2021
@pimeys pimeys mentioned this issue Jul 2, 2021
Merged
@janpio
Copy link
Member Author

janpio commented Jul 2, 2021 •
edited

New formatter engine unfortunately did not make it into a Insider build of VSCode extension yet, as the macOS tests are failing, see internal Slack: https://prisma-company.slack.com/archives/CKCQQGXJM/p1625264430037900

@janpio janpio added the kind/improvement An improvement to existing feature and code. label Jul 2, 2021
@janpio
Copy link
Member Author

janpio commented Jul 2, 2021

VSCode is unstuck, so I can not confirm this works as expected:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pimeys pimeys

@tomhoule tomhoule

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: referential actions topic: schema validation topic: schema
Projects
None yet
Milestone
2.27.0
Development

Successfully merging a pull request may close this issue.

Correct attribute highlighting prisma/prisma-engines
3 participants
@pimeys @janpio @tomhoule