Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWC: Reserved Word Clashes Epic #7963

Closed
7 tasks done
matthewmueller opened this issue Jun 30, 2021 · 4 comments
Closed
7 tasks done

RWC: Reserved Word Clashes Epic #7963

matthewmueller opened this issue Jun 30, 2021 · 4 comments
Labels
kind/epic A high-level initiative that has many subtasks. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: reserved words See https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#naming-conventions

Comments

@matthewmueller
Copy link
Contributor

matthewmueller commented Jun 30, 2021

Problem

We have a number of issues around user input clashing with generated types. We should look into these issues holistically and try to solve them once and for all instead of playing whack-a-mole.

Known Issues

Or via label: https://github.com/prisma/prisma/issues?q=is%3Aopen+label%3A%22topic%3A+reserved+words%22

@matthewmueller matthewmueller added kind/bug A reported bug. topic: reserved words See https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#naming-conventions team/client Issue for team Client. topic: epic labels Jun 30, 2021
@matthewmueller matthewmueller changed the title [Epic] Resolve Reserved Word Clashes [Epic] Reserved Word Clashes Jun 30, 2021
@matthewmueller matthewmueller added kind/epic A high-level initiative that has many subtasks. and removed kind/bug A reported bug. topic: epic labels Jul 2, 2021
@matthewmueller matthewmueller changed the title [Epic] Reserved Word Clashes RWC: Reserved Word Clashes Epic Jul 2, 2021
@pantharshit00
Copy link
Contributor

I think #8153 can also be taken into this.

@cprieto cprieto self-assigned this Oct 19, 2021
@matthewmueller matthewmueller added the tech/typescript Issue for tech TypeScript. label Nov 2, 2021
@matthewmueller
Copy link
Contributor Author

Unable to repro on engines side, probably a typescript issue.

@darklight9811
Copy link

@matthewmueller Move reserved keywords into _key or $key scope to allow users to use their names. Having an issue because my domain rule can't accept another name besides key without looking really silly :/

@SevInf
Copy link
Contributor

SevInf commented Jul 20, 2023

All issues, mentined in this epic are fixed by now and the fixes will be available in Prisma 5.1. Closing the epic now.

@SevInf SevInf closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic A high-level initiative that has many subtasks. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: reserved words See https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#naming-conventions
Projects
None yet
Development

No branches or pull requests

5 participants