type with name "News" cannot be deployed

[attilah]

Current behavior

I wanted to create a type named News but an error was returned

Reproduction

try to deploy this datamodel

type News {
  id: ID! @unique
}

Error:

ERROR: All fields within 'Query' type should have unique names! Non-unique fields: 'news'.

{
  "errors": [
    {
      "requestId": "api:api:cjd18y9me003d0138ifqm95q9",
      "message": "All fields within 'Query' type should have unique names! Non-unique fields: 'news'."
    }
  ],
  "status": 500
}

Expected behavior?

News type created.

[johannpinson]

Same thing, but the model seems to be created well.
Just the generation of the schema looks fail (I check my RDS and the table "News" is created well)

[johannpinson]

Related to #48

[marktani]

Yup, the issue here is that the plural form of News will be News - so both queries for many news - news: [News!]! - and single news - news: News are called news, leading to the name clash.

[johannpinson]

Yes I see some issues about it (#48 and #253 in particular)

And specially one about the directive @queries: https://github.com/graphcool/prisma/issues/1342
This issue is closed but doesn't to work, any info about it?

Another solution will be about create special case for the plural detection here:
https://github.com/graphcool/prisma/blob/d20b3674e241c2068f6560ca20cf908f667def61/server/servers/api/src/main/scala/com/prisma/api/schema/SchemaBuilder.scala#L252-L259

And evo-influctor already detect some case:
https://github.com/atteo/evo-inflector/blob/64ab921bbdeb797e6aa6469eb7a53320b505221a/src/main/java/org/atteo/evo/inflector/English.java#L146

One possibility will to detect when evo return the same string as the plural and so change the rule by adding the all before, like on graph.cool
In this case, we will have a query named allNews

What do you think about this solution?

[attilah]

using all prefix for the collection, or an Item (NewsItem) suffix for the single ones is a good way, whatever fix you decide I think this option should be handed to the developer and make it a configurable option.

As a personal preference I like the News and NewsItem more.

[marktani]

Closing as duplicate of #2659.