Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

Metadata for mutation callbacks #8

Closed
thomaslove opened this issue Oct 1, 2016 · 3 comments
Closed

Metadata for mutation callbacks #8

thomaslove opened this issue Oct 1, 2016 · 3 comments

Comments

@thomaslove
Copy link

thomaslove commented Oct 1, 2016

Can we have an optional extra field on action to be able to set a secret that we can validate on the webhook server's side. Github's implementation seems solid.

https://developer.github.com/webhooks/securing/

It just involves hashing the secret and attaching it to the "X-Hub-Signature" header when you make the POST request

@schickling
Copy link
Member

Yes, that makes a lot of sense. I've added it to our roadmap: https://github.com/graphcool/feature-requests/projects/1

@marktani marktani changed the title Set secrets on action webhooks Set secrets on mutation callbacks Feb 5, 2017
@marktani marktani changed the title Set secrets on mutation callbacks Metadata for mutation callbacks Feb 25, 2017
@marktani
Copy link
Contributor

Setting a custom authorization header, or other headers, would be very useful as well

@marktani
Copy link
Contributor

marktani commented Mar 3, 2017

Closing in favor of #118.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants