This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Fix hooks experience in CLI #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyenduz
changed the title
timsuchanek
pushed a commit
that referenced
this pull request
Jun 5, 2018
* fix: hooks, check for exit code to update hook output * fix: hooks, peek error for better failure handling
cmcinroy
pushed a commit
to cmcinroy/prisma
that referenced
this pull request
Jun 11, 2018
* fix: hooks, check for exit code to update hook output * fix: hooks, peek error for better failure handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to solve #2362 and related issues (#2560).
Observations:-
Underlying packages (
graphql-cli,graphql-configetc) do not write tostderror emit non-zero status code on failurePrisma CLI does not always check the status
There are (race?)-conditions that call stop function and render green unintended messages on CLI
We cannot aggressively fail
prisma deployon failinghooksas deployment might already be done. Need to extract the errors gracefully and communicate them back to the user