Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve introspect command, backup behavior #1369

Closed
janpio opened this issue Jan 17, 2020 · 2 comments
Closed

Improve introspect command, backup behavior #1369

janpio opened this issue Jan 17, 2020 · 2 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@janpio
Copy link
Member

janpio commented Jan 17, 2020

Current output of successful introspection:

C:\Users\Jan\Documents\throwaway\initTest
λ prisma2 introspect
Introspecting based on datasource defined in prisma\schema.prisma …
Done with introspection in 226ms

Moved existing prisma\schema.prisma to prisma\schema.backup.prisma
Wrote prisma\schema.prisma

It is unclear if this backup behavior is indeed what we want the command to do.

@pantharshit00 pantharshit00 added kind/improvement An improvement to existing feature and code. process/candidate labels Jan 21, 2020
@pantharshit00
Copy link
Contributor

I think the behaviour is correct here, you can use the backup file to diff against the introspected model and revert back if you don't get the intented model you want.

We just need to spec this out properly though.

@janpio
Copy link
Member Author

janpio commented Jan 31, 2020

Decision by @sorenbs: Remove backup behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

No branches or pull requests

4 participants