Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Introspection] Investigate and improve introspection speed #1494

Closed
janpio opened this issue Jan 31, 2020 · 3 comments
Closed

[Introspection] Investigate and improve introspection speed #1494

janpio opened this issue Jan 31, 2020 · 3 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code. topic: introspection
Milestone

Comments

@janpio
Copy link
Member

janpio commented Jan 31, 2020

Right now Introspection sometimes fails for big schemas (See #1493). We should investigate and improve the behavior of Introspection by e.g. parallelizing queries or similar.

@janpio janpio added process/candidate kind/improvement An improvement to existing feature and code. topic: introspection labels Jan 31, 2020
@janpio janpio added this to the Preview 22 milestone Jan 31, 2020
@tomhoule
Copy link
Contributor

tomhoule commented Feb 6, 2020

Magento has ~400 tables, we're doing ~1200 SQL queries to introspect at the moment (see the following log).

logs.txt

We should be able to cut the number of queries by quite a lot with a small amount of work, so I'll try that.

@tomhoule
Copy link
Contributor

tomhoule commented Feb 6, 2020

After a first series of PRs, the number of introspection queries on the same database is down to 5 (from ~1400).

@tomhoule
Copy link
Contributor

tomhoule commented Feb 7, 2020

Current status:

  • we optimized introspection queries on MySQL and now it is fast™
  • we optimized one query on postgres (columns), but the others are more complicated, so we will do it when we have time or it becomes a necessity

@janpio janpio assigned tomhoule and unassigned do4gr Feb 13, 2020
@janpio janpio closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. topic: introspection
Projects
None yet
Development

No branches or pull requests

3 participants